Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long diagnostic for E0538 #51510

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Long diagnostic for E0538 #51510

merged 2 commits into from
Jun 12, 2018

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Jun 11, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:23:59] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0538 (line 9384) stdout ----
[01:23:59] error: unexpected token: `,`
[01:23:59]  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:9386:19
[01:23:59]   |
[01:23:59] 4 |     since="1.0.0"),
[01:23:59]   |                   ^ unexpected token after this
[01:23:59] 
[01:23:59] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0538 (line 9384)' panicked at 'Some expected error codes were not found: ["E0538"]', librustdoc/test.rs:330:13
[01:23:59] 
[01:23:59] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0538 (line 9400) stdout ----
[01:23:59] error: unexpected token: `,`
[01:23:59]  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:9402:19
[01:23:59]  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:9402:19
[01:23:59]   |
[01:23:59] 4 |     since="1.0.0"),
[01:23:59]   |                   ^ unexpected token after this
[01:23:59] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0538 (line 9400)' panicked at 'couldn't compile the test', librustdoc/test.rs:325:17
[01:23:59] 
[01:23:59] 
[01:23:59] failures:
---
[01:23:59] 
[01:23:59] 
[01:23:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:23:59] Build completed unsuccessfully in 0:41:19
[01:23:59] make: *** [check] Error 1
[01:23:59] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0cb4f3bb
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Havvy Havvy force-pushed the diagnostic-list branch from 6f07335 to 4574825 Compare June 11, 2018 22:50
GuillaumeGomez
GuillaumeGomez reviewed Jun 12, 2018
View reviewed changes
src/libsyntax/diagnostic_list.rs Outdated
@@ -93,6 +93,36 @@ For more information about the cfg attribute, read:
https://doc.rust-lang.org/reference.html#conditional-compilation
"##,

E0538: r##"
Attribute contains multiple of the same meta item.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "Attribute contains same meta item more than once"? (it's a real question, I'm not an english native so it's just a suggestion!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is slightly better wording.

@GuillaumeGomez
Copy link
Member

I'd like to have an english native's opinion on my suggestion, but otherwise, it looks good for me. Good job! :)

@GuillaumeGomez
Copy link
Member

Then let's go for it!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 12, 2018

📌 Commit e9e0ca0 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 12, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51510 - Havvy:diagnostic-list, r=GuillaumeG…
398e570 
…omez

Long diagnostic for E0538

r? @GuillaumeGomez
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 12, 2018
Merged
bors added a commit that referenced this pull request Jun 12, 2018
@bors
Auto merge of #51521 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
b68432d 
Rollup of 3 pull requests

Successful merges:

 - #51261 (Updated RELEASES.md for 1.27.0)
 - #51502 (Make parse_seq_to_end and parse_path public)
 - #51510 (Long diagnostic for E0538)

Failed merges:
@bors bors merged commit e9e0ca0 into rust-lang:master Jun 12, 2018
@Havvy Havvy deleted the diagnostic-list branch August 11, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Havvy @rust-highfive @GuillaumeGomez @bors